Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add use citation from H->aa ATLAS CONF note #2306

Merged
merged 1 commit into from
Sep 4, 2023
Merged

docs: Add use citation from H->aa ATLAS CONF note #2306

merged 1 commit into from
Sep 4, 2023
+9 −0

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Aug 29, 2023 •
edited
Loading

Description

Add use citation from 'Search for short- and long-lived axion-like particles in H → a a → 4 γ decays with the ATLAS experiment at the LHC'

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Add use citation from 'Search for short- and long-lived axion-like particles
  in H → a a → 4 γ decays with the ATLAS experiment at the LHC'.
   - https://inspirehep.net/literature/2691210
   - http://cds.cern.ch/record/2867933
   - ATLAS-CONF-2023-040

@matthewfeickert matthewfeickert added docs Documentation related need-to-backport tmp label until can be backported to patch release branch labels Aug 29, 2023
@matthewfeickert matthewfeickert self-assigned this Aug 29, 2023
@matthewfeickert matthewfeickert requested a review from kratsg August 29, 2023 13:03
@matthewfeickert
Copy link
Member Author

Relevant RTD build: https://pyhf--2306.org.readthedocs.build/en/2306/citations.html#use-citations

We haven't had a use citation form a CONF note that I know of yet(?), or if we have it has gotten updated into a publication and then removed, so @kratsg let me know if you find this BibTeX format acceptable.

@codecov
Copy link

codecov bot commented Aug 29, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (205eecf) 98.30% compared to head (cc6b151) 98.30%.

❗ Current head cc6b151 differs from pull request most recent head ac2897d. Consider uploading reports for the commit ac2897d to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2306   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files          69       69           
  Lines        4536     4536           
  Branches      802      802           
=======================================
  Hits         4459     4459           
  Misses         45       45           
  Partials       32       32
Flag Coverage Δ
contrib 97.88% <ø> (ø)
doctest 61.04% <ø> (ø)
unittests-3.10 96.31% <ø> (ø)
unittests-3.11 96.31% <ø> (ø)
unittests-3.8 96.34% <ø> (ø)
unittests-3.9 96.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewfeickert matthewfeickert force-pushed the docs/add-ATLAS-CONF-2023-040 branch from eab60bc to cc6b151 Compare August 31, 2023 00:10
@matthewfeickert
docs: Add use citation from H->aa ATLAS CONF note
ac2897d 
* Add use citation from 'Search for short- and long-lived axion-like particles
  in H → a a → 4 γ decays with the ATLAS experiment at the LHC'.
   - c.f. https://inspirehep.net/literature/2691210
   - http://cds.cern.ch/record/2867933
   - ATLAS-CONF-2023-040
@matthewfeickert matthewfeickert force-pushed the docs/add-ATLAS-CONF-2023-040 branch from cc6b151 to ac2897d Compare September 4, 2023 17:10
@matthewfeickert
Copy link
Member Author

I'm going to approve and merge this myself. As always, PRs approved by a single core dev can be reverted as needed by the rest of the dev team.

@matthewfeickert matthewfeickert merged commit 65a1f6d into main Sep 4, 2023
18 checks passed
@matthewfeickert matthewfeickert deleted the docs/add-ATLAS-CONF-2023-040 branch September 4, 2023 17:55
@matthewfeickert matthewfeickert mentioned this pull request Sep 6, 2023
Merged
4 tasks
@matthewfeickert matthewfeickert removed the need-to-backport tmp label until can be backported to patch release branch label Sep 6, 2023
matthewfeickert added a commit that referenced this pull request Sep 6, 2023
@matthewfeickert
docs(backport): Update docs requirements and use citations (#2320)
a8b6fce 
* Backport:
   - PR #2291
   - PR #2300
   - PR #2306
   - PR #2308
   - PR #2309
   - PR #2312
   - PR #2315
   - PR #2316
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kratsg kratsg Awaiting requested review from kratsg

Assignees

@matthewfeickert matthewfeickert

Labels
docs Documentation related
Projects
pyhf v0.8.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matthewfeickert